Print the Microsoft submission obligation into the release summary - #102
Merged
Conversation
Antivirus false-positive clearances are granted per hash. The v1.122.4 clearance on 2026-08-12 covers exactly that binary, so every release starts over with the machine-learning models no matter how small the change. That obligation was living in a checklist, which is the same place the previous one lived when it got missed. The release job now writes the new SHA-256, the portal link, and the priority caveat into the run summary, so it appears where the release is already being validated instead of depending on recall. Section 209 pins the step: it exists, links the portal, publishes the hash, writes to the summary, and carries the same version-bump gate as the build steps it follows. Also adds the winget manifests for 1.122.4. The first submission was withdrawn in July because CI retention deleted the previous release and killed the manifest's InstallerUrl between versions; that retention step was removed in #95, so the URL now stays alive. Manifests pass winget validate and the installer URL returns 200. One encoding trap fixed while writing the tests. ci.yml has no BOM, and Windows PowerShell 5.1 decodes BOM-less files as ANSI, so its em-dashes arrive as mojibake while pwsh 7 reads them correctly. The suite runs both ways -- directly under pwsh, and under powershell.exe via Validate-Release -- so an assertion matching non-ASCII text in that file passed one host and failed the other. Section 209 now reads ci.yml as UTF-8 explicitly and anchors only on ASCII. Verified green under both hosts. Structural tests 5485 -> 5493.
TheAbider
force-pushed
the
ci/wdsi-submission-reminder
branch
from
August 13, 2026 05:29
e4037db to
8a92794
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Antivirus false-positive clearances are granted per hash. Microsoft cleared v1.122.4 on
2026-08-12 — that covers exactly
658edcc5…and nothing else, so every future release starts overwith the ML models regardless of how small the change is.
That obligation was sitting in a checklist. So was the last one, right before it got missed.
What
The release job prints it into the run summary — new SHA-256, portal link, and the priority
caveat (the portal's hidden default is Low, whose own label says submissions "may never be
processed by an analyst"). It surfaces where the release is already being validated rather than
depending on anyone's memory.
winget manifests for 1.122.4. The July submission was withdrawn because CI retention deleted
the previous release and killed the manifest's
InstallerUrlbetween versions. That step wasremoved in #95, so URLs stay alive now.
winget validatepasses and the installer URL returns 200.Tests
Section 209 gains 5 assertions: the step exists, links the portal, publishes the hash, writes to the
summary, and carries the same version-bump gate as the build steps around it.
An encoding trap, caught by the tests disagreeing with themselves
The new assertions passed under
pwshand failed underpowershell.exe. Cause:ci.ymlhas noBOM, and Windows PowerShell 5.1 decodes BOM-less files as ANSI, so its em-dashes arrive as
mojibake while pwsh 7 reads them as UTF-8. The suite runs both ways — directly under pwsh, and
under
powershell.exefromlocal/Validate-Release.ps1— so any assertion matching non-ASCII textin that file is host-dependent.
Fixed at both levels: Section 209 now reads
ci.ymlwith-Encoding UTF8explicitly (fixes theclass of bug for every assertion against that file) and anchors only on ASCII (belt and braces).
Verified identical results under both hosts.
Worth knowing generally: this workflow is full of em-dashes and box-drawing characters, so the same
trap is waiting for any future assertion that matches them.
Structural tests 5485 → 5493. Full gate: 42 passed / 0 failed / 0 warnings, suite 5493/5493 —
run through
Validate-Release, i.e. the Windows PowerShell 5.1 path that was failing.On merge
No version bump — this does not cut a release.