rsz: Fix UB in performEarlySizingRound - #11195
Merged
Merged
Conversation
…gRound Signed-off-by: Mike Inouye <mikeinouye@google.com> Co-authored-by: Simon Bucher <ebners@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the call to findBufferSizes() to the beginning of the RepairDesign::performEarlySizingRound function, ensuring it executes before user annotations are tracked and other processing occurs. There are no review comments, and I have no feedback to provide.
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c52ede8043
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
mikesinouye
changed the title
jhkim-pii
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In OpenSTA when a net has no explicit set_max_fanout constraint sta_->checkFanout() returns max_fanout sta::INF, 1e30f. openroad checks (max_fanout <= 0) { max_fanout = 1e9; } which doesn't modify the 1e30f.
When passing max_fanout into performGainBuffering(..., int max_fanout), this results in int overflow (1e30 > INT_MAX), triggers UBSan.
Type of Change
Impact
Prevent ub in repair_design -pre_placement
Verification
./etc/Build.sh).