gpl: accumulate nonPlaceArea before multiplying density - #11123
Open
LucasYuki wants to merge 2 commits into
Open
gpl: accumulate nonPlaceArea before multiplying density#11123LucasYuki wants to merge 2 commits into
LucasYuki wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors BinGrid::updateBinsNonPlaceArea in nesterovBase.cpp to accumulate raw non-place areas in a temporary vector before scaling and adding them to the bins, and updates getOverlapArea to return int64_t instead of float. The review feedback suggests wrapping this new accumulation logic in a check to ensure pb_->nonPlaceInsts() is not empty, which avoids unnecessary memory allocation and loop overhead when there are no non-placeable instances.
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
openroad-ci
force-pushed
the
gpl-accumulate-nonPlaceArea
branch
from
August 18, 2026 15:37
93a8da1 to
84e99b1
Compare
Contributor
Author
|
Blocked by issue #11192. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accumulate the non-place area before multiplying the density to reduce rounding errors.
With this PR, PR #11085 becomes a no-op.
Type of Change
Impact
This slightly changes some test results.
Verification
./etc/Build.sh).Related Issues
#11085