Fix the broken slang alias.#10814
Conversation
|
this fixes the broken symbolic link I was complaining about in #10500 (review) @oharboe |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Thank you! I have no idea what this means. My choice is between accepting stuff from Claude for a lot of these things or have no solution at all. I have no mental model of what is going on here. |
|
@codex review |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the path parameter in MODULE.bazel from "bazel" to ".". Feedback suggests avoiding the use of the workspace root "." as it can cause circular symlink issues and performance degradation, recommending a more specific subdirectory instead.
It was using a path 'bazel/', but that path already exists in the main project, so bazel ended up symlinking to that directory. Unclear how that ever worked, or if bazel internally worked around the glitch, but this should fix it. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260704-fix-slang-alias
branch
from
b5ef409 to
7cdef5c
Compare
3 participants
It was using a path 'bazel/', but that path already exists in the main project, so bazel ended up symlinking to that directory. Unclear how that ever worked, or if bazel internally worked around the glitch, but this should fix it.