Skip to content

dpl/dpo: properly load fixed instances orientation#10793

Open
gudeh wants to merge 4 commits into
The-OpenROAD-Project:masterfrom
gudeh:dpl-dpo-load-macro-flipping
Open

dpl/dpo: properly load fixed instances orientation#10793
gudeh wants to merge 4 commits into
The-OpenROAD-Project:masterfrom
gudeh:dpl-dpo-load-macro-flipping

Conversation

@gudeh

@gudeh gudeh commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

The introduction of the pixels grid to DPO required painting and the initialization of instances orientation, which was performed at PR #10267. Although it was done skipping fixed instances. I see no reason to skip them, it even introduces issues to flipped macros, such as in issue #10677 which has a flipped macro on input ODB.

This PR excludes the skipping of fixed macros when initializing the orientation of instances for DPO.

Type of Change

  • Bug fix

Impact

Properly initialize fixed instances orientation at DPO.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Related Issues

This PR solves the 4 reproducibles at #10677

gudeh added 4 commits July 1, 2026 13:52
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
@gudeh gudeh requested a review from a team as a code owner July 1, 2026 15:40
@gudeh gudeh requested a review from osamahammad21 July 1, 2026 15:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Opendp::improvePlacement to adjust the orientation of all cell nodes, including fixed ones, and introduces a debug pause and log message before initializing the ShiftLegalizer. It also changes the drawing color from white to orange in Graphics::drawObjects. There are no review comments, so no additional feedback is provided.

@gudeh

gudeh commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

I am running a secure-CI at: https://jenkins.openroad.tools/blue/organizations/jenkins/OpenROAD-flow-scripts-Private/detail/secure-dpl-dpo-load-macro-flipping/4/pipeline

I am not sure if we have flipped macros on our designs, if we do this may imply functional modifications.

@osamahammad21 osamahammad21 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge iff no secure-ci impact.

@gudeh

gudeh commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

With the user's reproducible I see the issue being solved nicely. Although I don't yet understand why we see differences in secure-CI. I did not observe an incorrectly flipped macro as I did with the user's design. I wish to understand this before merging. I suspect it is just some small fixed instances with incorrect flipping. I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants