changes to accomodate for new changes in OpenSTA 6/30 pulling latest#10790
Draft
dsengupta0628 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the usage of hasSequentials() with isSequential() on LibertyCell objects across various source files to align with API updates. Additionally, it updates EstimateParasitics.tcl to use get_name for the corner variable in a warning message, updates the src/sta subproject commit, and adjusts a test expectation file. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update OpenSTA The-OpenROAD-Project/OpenSTA#379
Type of Change
Impact
Power.cc changed to have one extra iteration count for activity propagation
cleanup · parallaxsw/OpenSTA@c81f0c1 and line in Power::ensureActivities (power/Power.cc):
This change causes one extra activity-propagation pass (50 instead of 49; max_activity_passes_ = 50).
I regoldened one failing regression but this can drift power in some designs where activity propagation is not well behaved.
Verification
./etc/Build.sh).