Skip to content

changes to accomodate for new changes in OpenSTA 6/30 pulling latest#10790

Draft
dsengupta0628 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:or_update_sta_latest_0629
Draft

changes to accomodate for new changes in OpenSTA 6/30 pulling latest#10790
dsengupta0628 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:or_update_sta_latest_0629

Conversation

@dsengupta0628

Copy link
Copy Markdown
Contributor

Summary

Update OpenSTA The-OpenROAD-Project/OpenSTA#379

  1. change hasSequential to isSequential as former is deprecated
  2. regolden zerosoc_pad.tcl as the iteration max is now changed and this was a non-converging activity propagation regression anyways
  3. upstream changed sta::scenes to return Scene objects instead of name strings. So OpenROAD's src/est/src/EstimateParasitics.tcl needed to be updated to not use string-interpolated $corner into the EST-0018 warning like utl::warn EST 18 "wire capacitance for corner [get_name $corner] is zero...

Type of Change

  • New feature

Impact

Power.cc changed to have one extra iteration count for activity propagation
cleanup · parallaxsw/OpenSTA@c81f0c1 and line in Power::ensureActivities (power/Power.cc):

  -  while (!regs.empty() && pass < max_activity_passes_) {
  +  while (!regs.empty() && pass <= max_activity_passes_) {

This change causes one extra activity-propagation pass (50 instead of 49; max_activity_passes_ = 50).
I regoldened one failing regression but this can drift power in some designs where activity propagation is not well behaved.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 self-assigned this Jul 1, 2026
@github-actions github-actions Bot added the size/S label Jul 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the usage of hasSequentials() with isSequential() on LibertyCell objects across various source files to align with API updates. Additionally, it updates EstimateParasitics.tcl to use get_name for the corner variable in a warning message, updates the src/sta subproject commit, and adjusts a test expectation file. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant