added layer name to min pitch message#10788
Draft
jeffng-or wants to merge 1 commit into
Draft
Conversation
clang fix Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a format string issue in the error logging of src/pdn/src/straps.cpp by adding a placeholder and passing the layer name. The feedback points out a minor typo in the error message ("atleast" instead of "at least") and suggests a correction.
| utl::PDN, | ||
| 175, | ||
| "Pitch {:.4f} is too small for, must be atleast {:.4f}", | ||
| "Pitch {:.4f} is too small for {}, must be atleast {:.4f}", |
Contributor
There was a problem hiding this comment.
There is a minor typo in the error message: "atleast" should be written as two words ("at least").
Suggested change
| "Pitch {:.4f} is too small for {}, must be atleast {:.4f}", | |
| "Pitch {:.4f} is too small for {}, must be at least {:.4f}", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added missing layer name to minimum pitch message
Type of Change
Impact
Previous message didn't indicate the layer that was failing the minimum pitch check
Verification
./etc/Build.sh).Related Issues
None