Restrucgture.cpp: make sure abc start/end namespace macros are defined.#10450
Open
hzeller wants to merge 1 commit into
Open
Restrucgture.cpp: make sure abc start/end namespace macros are defined.#10450hzeller wants to merge 1 commit into
hzeller wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the abc_global.h header to Restructure.cpp to establish the abc namespace. The reviewer suggests improving consistency by using explicit namespace prefixes or using declarations for ABC commands and recommends making strategy headers self-contained by including abc_global.h directly within them to ensure they are not dependent on inclusion order.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hzeller
force-pushed
the
feature-20260517-abc-ns-inc
branch
from
142c3f5 to
4f0481a
Compare
Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260517-abc-ns-inc
branch
from
4f0481a to
e6faad4
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
Should we add a no sort around that include? |
QuantamHD
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.