Version.hh is supplied by :openroad_version; don't duplicate in :ord#10436
Conversation
Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the BUILD.bazel file by removing include/ord/Version.hh from the :ord library's headers and adding an includes path to the :openroad_version target. The review feedback suggests that the :ord library should explicitly depend on :openroad_version to ensure header availability and satisfy Bazel layering checks. Additionally, there is a suggestion to expand the includes list for :openroad_version to support flat include paths for the version header.
|
clang-tidy review says "All clean, LGTM! 👍" |
The `-Iinclude/ord` was not needed and unnecessarily allowed these headers to be included without any prefix. Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Looks good ? |
|
mmh, why do these checks hang in the CI queue for multiple days ? Maybe they need a restart ? |
It seems that they've failed, but the status wasn't updated here in the PR page. I've restarted them |
eder-matheus
merged commit d4c534c
into
The-OpenROAD-Project:master
2 participants
No description provided.