-
Notifications
You must be signed in to change notification settings - Fork 506
validate post GRT WNS opto #4320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
19eac4d
ef20f12
3d76797
94cbe82
5d56670
07278a6
106213b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,6 +87,29 @@ proc global_route_helper { } { | |
| report_metrics 5 "global route post repair timing" | ||
| } | ||
|
|
||
| if { $::env(OPT_POST_GRT_WNS) } { | ||
| log_cmd global_route -start_incremental | ||
| log_cmd detailed_placement {*}$dpl_args | ||
| check_placement -verbose | ||
| # Route only the modified net by DPL | ||
| log_cmd global_route -end_incremental {*}$res_aware \ | ||
| -congestion_report_file $::env(REPORTS_DIR)/congestion_post_repair_timing_opt_wns.rpt | ||
|
|
||
| set repair_timing_args \ | ||
| [list -setup -sequence "vt_swap reroute" -skip_last_gasp -repair_tns 0 -verbose] | ||
| if { [env_var_exists_and_non_empty MATCH_CELL_FOOTPRINT] } { | ||
| lappend repair_timing_args -match_cell_footprint | ||
| } | ||
| if { $::env(SETUP_SLACK_MARGIN) != 0 } { | ||
| lappend repair_timing_args -setup_margin $::env(SETUP_SLACK_MARGIN) | ||
| } | ||
| repair_timing {*}$repair_timing_args | ||
|
|
||
| if { $::env(DETAILED_METRICS) } { | ||
| report_metrics 5 "global route post repair timing_opt_wns" | ||
| } | ||
| } | ||
|
precisionmoon marked this conversation as resolved.
|
||
|
|
||
| # Running DPL to fix overlapped instances | ||
| # Run to get modified net by DPL | ||
| log_cmd global_route -start_incremental | ||
|
|
@@ -97,12 +120,13 @@ proc global_route_helper { } { | |
| -congestion_report_file $::env(REPORTS_DIR)/congestion_post_repair_timing.rpt | ||
| } | ||
|
|
||
|
|
||
| log_cmd global_route -start_incremental | ||
| recover_power_helper | ||
| # Route the modified nets by rsz journal restore | ||
| log_cmd global_route -end_incremental {*}$res_aware \ | ||
| -congestion_report_file $::env(REPORTS_DIR)/congestion_post_recover_power.rpt | ||
| if { !$::env(OPT_POST_GRT_WNS) } { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With Useful? React with 👍 / 👎.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @precisionmoon this could be a cause of wns improvement as we know recover_power can sometimes damage it. We should fix this and retest. |
||
| log_cmd global_route -start_incremental | ||
| recover_power_helper | ||
| # Route the modified nets by rsz journal restore | ||
| log_cmd global_route -end_incremental {*}$res_aware \ | ||
| -congestion_report_file $::env(REPORTS_DIR)/congestion_post_recover_power.rpt | ||
| } | ||
|
|
||
| if { | ||
| !$::env(SKIP_ANTENNA_REPAIR) && | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
defaults.pyexports JSON defaults,MATCH_CELL_FOOTPRINTis present as the non-empty string0in normal flows that do not enable it. This condition therefore always appends-match_cell_footprintfor the new post-GRT WNS repair pass, unlikerepair_timing_helper/recover_power_helperwhich only add the flag when the variable equals1; on libraries where useful VT swaps do not share a footprint, the default pass will be more constrained than requested and can miss the intended WNS improvement.Useful? React with 👍 / 👎.