-
Notifications
You must be signed in to change notification settings - Fork 487
Secure fix missing para dbmodnet #4050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
openroad-ci
wants to merge
16
commits into
The-OpenROAD-Project:master
Choose a base branch
from
The-OpenROAD-Project-staging:secure-fix_missing_para_dbmodnet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f953347
Add final check all drivers have parasitic annotation
povik 590b815
fix missing para on dbterm
dsengupta0628 857bc84
Merge remote-tracking branch 'origin/master' into secure-fix_missing_…
dsengupta0628 cfc24d1
Merge branch 'master' into secure-fix_missing_para_dbmodnet
dsengupta0628 503c0d7
update openroad- again!
dsengupta0628 176bd4b
revert the proc to check missing para
dsengupta0628 04f2834
Merge branch 'master' into secure-fix_missing_para_dbmodnet
dsengupta0628 fe4b43a
update openroad
dsengupta0628 2f5d591
revert the final_report.tcl to original
dsengupta0628 b17fc9a
revert the final_report.tcl to original
dsengupta0628 ba6eaa3
merged with latest
dsengupta0628 7c57dc3
latest OR
dsengupta0628 9dd3494
Merge branch 'master' into secure-fix_missing_para_dbmodnet
dsengupta0628 fac3fa8
update OpenROAD for ORFS regoldening
dsengupta0628 ba99381
merged with latest orfs
dsengupta0628 d5b01c1
flow: update rules
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule OpenROAD
updated
31 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why this number oscillates so much- yesterday baseline was -46993 and today it was somehow regoldened to -320 and my code makes it back to -47000. This is also the test that gets affected by my change- with correct para now, it fallsback to the PRIMA dcalc path and - without my isExternal fix, it would have crashed in PRIMA. So this testcase is really stress testing my change