chore: remove multi-line comment blocks added in PR #60 - #63
Closed
poxet wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #64, which carries this change together with the version bump and the mission.md corrections in a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up two multi-line inline comment blocks I introduced in #60, which break the Coding Guidelines: single-line inline comments only, no multi-line inline comment blocks.
.github/workflows/build.ymlThe
Test with coveragestep had a one-line comment already; I appended two more lines about the Microsoft.Testing.Platform migration, making it a three-line block. Those two lines are removed — the flags are self-describing andglobal.jsondeclares the runner, so the explanation was history rather than something the file needs. The original single line about skipping Integration and TimeCritical tests stays.Tharga.Cache.Tests/AddCacheConcurrencyTests.csThe note on
MarkerTypewas two lines; reduced to one:// Nesting Marker in itself yields N distinct cache types without N declared classes.This one earns its single line — the nested-generic trick is genuinely non-obvious from the code alone, which is exactly the case exception (b) exists for.
Not touched
build.ymlhas three pre-existing multi-line blocks (theCompute version,Resolve build versionandPush to NuGetsteps). They predate my work, so removing them is a separate decision and not folded in here.Comment-only changes; verified with a Release build and the CI-filtered suite: 467 tests, 465 passed, 2 skipped.