Skip to content

chore: remove multi-line comment blocks added in PR #60 - #63

Closed
poxet wants to merge 1 commit into
masterfrom
chore/remove-comment-blocks
Closed

chore: remove multi-line comment blocks added in PR #60#63
poxet wants to merge 1 commit into
masterfrom
chore/remove-comment-blocks

Conversation

@poxet

@poxet poxet commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Cleans up two multi-line inline comment blocks I introduced in #60, which break the Coding Guidelines: single-line inline comments only, no multi-line inline comment blocks.

.github/workflows/build.yml

The Test with coverage step had a one-line comment already; I appended two more lines about the Microsoft.Testing.Platform migration, making it a three-line block. Those two lines are removed — the flags are self-describing and global.json declares the runner, so the explanation was history rather than something the file needs. The original single line about skipping Integration and TimeCritical tests stays.

Tharga.Cache.Tests/AddCacheConcurrencyTests.cs

The note on MarkerType was two lines; reduced to one:

// Nesting Marker in itself yields N distinct cache types without N declared classes.

This one earns its single line — the nested-generic trick is genuinely non-obvious from the code alone, which is exactly the case exception (b) exists for.

Not touched

build.yml has three pre-existing multi-line blocks (the Compute version, Resolve build version and Push to NuGet steps). They predate my work, so removing them is a separate decision and not folded in here.

Comment-only changes; verified with a Release build and the CI-filtered suite: 467 tests, 465 passed, 2 skipped.

@poxet

poxet commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #64, which carries this change together with the version bump and the mission.md corrections in a single PR.

@poxet poxet closed this Aug 17, 2026
@poxet
poxet deleted the chore/remove-comment-blocks branch August 17, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant