chore: bump version line to 1.1 for the FluentAssertions removal - #61
Closed
poxet wants to merge 2 commits into
Closed
chore: bump version line to 1.1 for the FluentAssertions removal#61poxet wants to merge 2 commits into
poxet wants to merge 2 commits into
Conversation
Contributor
Author
|
Superseded by #64, which carries this change together with the comment cleanup and the mission.md corrections in a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
MAJOR_MINORto1.1so the gh#55/#56 release publishes as 1.1.0 rather than 1.0.3.Why a minor rather than a patch
#60 removed the FluentAssertions reference from
Tharga.Cache. That is the right fix — the library never used it, and flowing it put the Xceed Community License on every consumer — but it is a compile-time break for anyone who was unknowingly relying on the transitive reference. That population is precisely the one that cannot anticipate the change, which is what makes a silent patch bump the wrong signal.Secondary, smaller: #60 also changed the
AddCacheregistration-accumulation semantics. Registrations no longer accumulate process-wide across service collections, and in a three-or-more-call sequence a call that does not mention a type now inherits the most recent value rather than the first-ever one.Effect
The version step reads
git tag -l "${MAJOR_MINOR}.*". No1.1.*tag exists, soPATCHstarts at0and the next master release publishes 1.1.0. The1.0.xtags are untouched.Sequencing
The release job for #60 is currently sitting at
waitingon the gated deployment, so nothing has published yet — this lands before the approval, and the fixes then reach NuGet as 1.1.0 in a single release. Approving the older waiting run instead would mint 1.0.3 and make this moot.