chore!: bump to 1.0, target net10.0 only, consume tier 3, declare licence - #54
Merged
Conversation
IncludeSymbols was on but SymbolPackageFormat was not set, so pack
emitted the legacy `Foo.<version>.symbols.nupkg`. That filename still
ends in `.nupkg`, so the release workflow's
for pkg in ./artifacts/*.nupkg
loop picked it up and pushed it as a *regular* package. nuget.org
rejected it as a duplicate of the main package — same id, same version —
and the `|| true` at the end of the push line swallowed the error, so
every release went green while publishing no symbols at all.
A `.snupkg` is not matched by that glob, and `dotnet nuget push` uploads
it alongside its `.nupkg` automatically. The artifact step already
uploads the whole ./artifacts directory, so the file survives the
hand-off from the build job to the release job.
No republish is needed; this takes effect on the next release.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ence Version - MAJOR_MINOR 0.4 -> 1.0. Cache was the last pre-1.0 package series in the toolkit. Frameworks - Tharga.Cache, .Blazor, .Mcp, .MongoDB and .Redis drop net8.0/net9.0 for net10.0 only. Both go out of support on 2026-11-10, and .Blazor had to move regardless since Tharga.Blazor 2.2.3 is net10.0 only. Dependencies - Tharga.MongoDB 2.11.2 -> 2.14.1, Tharga.Blazor 2.2.0 -> 2.2.3, Tharga.Mcp 0.1.6 -> 1.0.0, Tharga.Console 4.1.2 -> 4.2.0. Package metadata - Declared PackageLicenseExpression MIT on all six packages. The repo has an MIT LICENSE file but none of them ever said so, and every push logged "License missing". - Removed <Version> from all six projects. CI sets the version at build time, so the value here never reached the package - it only misled anyone reading the file, and it read 1.0.0 while the series shipped 0.4.x. - NU5048 added to NoWarn; PackageIconUrl is deliberate. CI - Version computed before the build and passed as -p:Version, so the assembly and the package agree. Previously only -p:PackageVersion was passed at pack time, leaving AssemblyVersion at 1.0.0.0 in every shipped assembly. The two conditional Pack steps collapse into one covering all six packages. - Guarded the version tag lookup with `|| true`. grep exits 1 when no tag matches the series - which is exactly what starting the new 1.0 series does - and the step would die under `bash -eo pipefail`. - A failed nuget push now fails the release; the loop ended in `|| true`. - SDK install narrowed to 10.0.x. Solution - Removed solution items for azure-pipelines.yml and buildnumber.yml, which no longer exist; added the workflow and LICENSE. Tests: 478 pass. FetchDataThrottleTests.ManyParallelCallsAreQueuedForDifferentTypes is timing-bounded (asserts 500-1200ms) and flaky - it fails intermittently on unmodified master too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 4 of the package cleanup sweep. Also carries the
snupkgsymbol fix originally opened on its own here.Version
MAJOR_MINOR 0.4 → 1.0 — Cache was the last pre-1.0 package series in the toolkit.
Frameworks
Tharga.Cache,.Blazor,.Mcp,.MongoDBand.Redisdrop net8.0/net9.0 for net10.0 only. Both go out of support 2026-11-10, and.Blazorhad to move regardless sinceTharga.Blazor2.2.3 is net10.0-only.Dependencies
Package metadata
License missing.SymbolPackageFormat=snupkg). The legacy.symbols.nupkgname still ends in.nupkg, so the push loop uploaded it as a regular package and nuget.org rejected it as a duplicate. Verified working end-to-end on Blazor, Crawler and all five MongoDB packages.<Version>from all six projects — it read1.0.0while the series actually shipped0.4.x.NU5048added to NoWarn;PackageIconUrlis deliberate.CI
-p:Version, so the assembly and package agree.|| true—grepexits 1 when no tag matches the series, which is exactly what starting the new 1.0 series does, and the step would otherwise die underbash -eo pipefail. This is the bug that broke Reporter's build in tier 1.|| true.Tests
478 pass.
FetchDataThrottleTests.ManyParallelCallsAreQueuedForDifferentTypesis timing-bounded (asserts 500–1200 ms) and flaky — it fails intermittently on unmodifiedmastertoo (2 of 3 runs there).