fix(pm_psci_s2idle): Update and enhance s2idle docs - #750
Open
ti-scaria wants to merge 2 commits into
Open
Conversation
ti-scaria
requested review from
StaticRocket,
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
July 20, 2026 07:43
github-actions
Bot
assigned
devarsht,
gehariprasath,
praneethbajjuri,
r-vignesh,
ti-scaria,
uditkumarti and
vishalmti
akashdeep-ti
suggested changes
Jul 20, 2026
StaticRocket
requested changes
Jul 20, 2026
StaticRocket
left a comment
StaticRocket
left a comment
Member
There was a problem hiding this comment.
There are other places where active voice should be used
akashdeep-ti
suggested changes
Jul 21, 2026
kwillis01
suggested changes
Jul 21, 2026
kwillis01
left a comment
kwillis01
left a comment
Contributor
There was a problem hiding this comment.
I really like the changes to the content, I think it will make it easier for users to read and implement in their system.
One big thing to note is I think we should go step by step in explaining how to set the CPU wakeup latency constraints. We should first explain what they are, the program needed to set them, and then how it is used.
kwillis01
suggested changes
Jul 23, 2026
kwillis01
left a comment
kwillis01
left a comment
Contributor
There was a problem hiding this comment.
There are still some vale warnings for passive voice that need to be fixed if possible
Member
kwillis01
approved these changes
Jul 23, 2026
StaticRocket
previously approved these changes
Jul 25, 2026
praneethbajjuri
previously approved these changes
Jul 27, 2026
akashdeep-ti
approved these changes
Jul 28, 2026
ti-scaria
dismissed stale reviews from praneethbajjuri and StaticRocket
via
July 28, 2026 08:10
7a95c85
Contributor
Author
|
Rebased the PR |
kwillis01
suggested changes
Jul 28, 2026
Update the s2idle docs with the correct AM62L power domain hierarchy and idle states derived from the latest release. Rewrite the mode selection logic by including the components involved and how they are used. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
Add S2idle feature to Key Release References section. This is a method that enables selection of low power mode at runtime. Signed-off-by: Scaria Kochidanadu <s-kochidanadu@ti.com>
kwillis01
approved these changes
Jul 29, 2026
Contributor
Author
|
@praneethbajjuri @StaticRocket Rebased the PR, could you re-approve |
praneethbajjuri
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the s2idle docs with the correct AM62L power domain hierarchy and idle states derived from the latest release.
Rewrite the mode selection explanation for clarity.