fix: reconcile terminal orders during cancel#93
Open
rupurt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
OrderManager.search_orders()for historical/Order/searchqueries so terminal orders can be retrieved, not only currently-open orders.get_order_by_id()to fall back from open-order search to historical order search.cancel_order()to reconcile terminal broker state after a failed cancel response:TrueFalsewithout raising a cancel submission exceptionWhy
A cancel request can race with broker-side fills or terminal status transitions. Before this change,
get_order_by_id()only searched open orders, socancel_order()could not reconcile the true terminal state and raisedProjectXOrderErrorfrom vague broker responses such as a failed cancel with no useful error detail.Impact
Callers can now distinguish an actual cancel failure from an order that became terminal while cancellation was in flight. This preserves the existing
boolreturn type while avoiding false hard failures for normal broker lifecycle races.Validation
uv run ruff check src/project_x_py/order_manager/core.py tests/order_manager/test_order_core.py tests/order_manager/test_core_advanced.py --fixuv run pytest tests/order_manager/test_order_core.py tests/order_manager/test_core_advanced.py