Skip to content

feat(agent): add kiro as an install target#10

Open
lxcario wants to merge 1 commit into
TestSprite:mainfrom
lxcario:feat/add-kiro-target
Open

feat(agent): add kiro as an install target#10
lxcario wants to merge 1 commit into
TestSprite:mainfrom
lxcario:feat/add-kiro-target

Conversation

@lxcario

@lxcario lxcario commented Jun 23, 2026

Copy link
Copy Markdown

Adds kiro as a new agent install target.

Changes

  • Added kiro to the AgentTarget type union
  • Added kiro entry to TARGETS map:
  • path: .kiro/skills/testsprite-verify/SKILL.md
  • mode: own-file
  • status: experimental
  • wrap: wrapSkill (same frontmatter as claude/antigravity)
  • Updated test coverage (68 tests passing in agent-targets.test.ts)
  • Updated DOCUMENTATION.md with kiro install example
  • Updated README.md supported targets list

Testing

  • npm run lint:fix - clean
  • npm run format - clean
  • npm run typecheck - clean
  • npm test (agent-targets.test.ts) - 68/68 passing

Summary by CodeRabbit

  • New Features

    • Added support for the kiro coding agent as an available target.
  • Documentation

    • Updated the README and onboarding docs to include kiro in supported agent lists and examples.
    • Reflected the increased number of supported installation targets in the documentation.
  • Tests

    • Expanded coverage to verify kiro is recognized, categorized correctly, and rendered consistently with other supported targets.

@zeshi-du

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new kiro agent target to the AgentTarget type and TARGETS mapping in src/lib/agent-targets.ts, configured as an experimental own-file target pointing to a SKILL.md path. Corresponding unit tests and documentation in README.md and DOCUMENTATION.md were updated to reflect this addition.

Changes

Kiro Agent Target Support

Layer / File(s) Summary
AgentTarget type and TARGETS entry
src/lib/agent-targets.ts
Adds 'kiro' to the AgentTarget union and a new TARGETS.kiro entry with status: 'experimental', mode: 'own-file', path .kiro/skills/testsprite-verify/SKILL.md, and the wrapSkill wrapper.
Tests for kiro behavior
src/lib/agent-targets.test.ts
Updates key-set, experimental-status, and own-file mode assertions, and adds a renderForTarget("kiro") test block plus inclusion in the content integrity suite.
Documentation updates
README.md, DOCUMENTATION.md
Adds kiro to Quickstart and Commands examples in README, and to the agent install examples/supported targets list (5 → 6) in DOCUMENTATION.md.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

A rabbit hopped in with a brand-new friend,
"kiro" joins the warren, targets extend!
Tests all green, docs in tow,
One more skill file ready to go. 🐇📄✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: adding kiro as a new agent install target.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
DOCUMENTATION.md (1)

115-124: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

kiro missing from own-file backup-behavior list.

kiro is configured as mode: 'own-file' in agent-targets.ts, so it is also subject to the --force .bak backup behavior described here, but line 124's list omits it.

📝 Proposed fix
-Re-running with `--force` on **own-file targets** (claude, cursor, cline, antigravity) backs up the existing file to `<path>.bak` first.
+Re-running with `--force` on **own-file targets** (claude, cursor, cline, antigravity, kiro) backs up the existing file to `<path>.bak` first.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@DOCUMENTATION.md` around lines 115 - 124, Add kiro to the own-file `--force`
backup-behavior list in the documentation, since it is also an own-file target
in `agent-targets.ts` and should be described alongside `claude`, `cursor`,
`cline`, and `antigravity`. Update the backup sentence in `DOCUMENTATION.md` so
the `kiro` target is explicitly included, matching the behavior of the own-file
mode.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@DOCUMENTATION.md`:
- Around line 115-124: Add kiro to the own-file `--force` backup-behavior list
in the documentation, since it is also an own-file target in `agent-targets.ts`
and should be described alongside `claude`, `cursor`, `cline`, and
`antigravity`. Update the backup sentence in `DOCUMENTATION.md` so the `kiro`
target is explicitly included, matching the behavior of the own-file mode.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7fddb421-cfcb-4b41-8c0e-7a6878a79a89

📥 Commits

Reviewing files that changed from the base of the PR and between 18f6e6e and 00805b3.

📒 Files selected for processing (4)
  • DOCUMENTATION.md
  • README.md
  • src/lib/agent-targets.test.ts
  • src/lib/agent-targets.ts

@zeshi-du

zeshi-du commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for adding kiro @lxcario! 🙏 Two unit tests are red because the new target changes the install-target count:

src/commands/agent.test.ts (70 tests | 2 failed)
 × runList > JSON mode emits array of {target, status, path, mode}
   → expected [...] to have a length of 5 but got 6
 × runInstall — all four own-file targets > installs all four own-file targets in one invocation
   → expected false to be true

Adding kiro makes 6 targets, so the length assertion (5) and the "four own-file targets" test need updating to include it.

⚠️ Heads-up on merge coordination: #29 (windsurf) and #57 (gemini) touch the same target list and the same count assertions. To keep these three from re-breaking each other's counts, we'll land them in sequence and may ask for a rebase at merge time — but updating the tests here is the right first step regardless. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants