fix(import): prevent duplicate MRs from metadata-only diffs#190
Merged
Conversation
Add isMetadataOnlyDiff() guard in pushRepoBranch — when all staged changes are just timestamp fields (lastUpdated, lastScan, syncedAt), skip branch creation and MR. Also fix test isolation: mock config.js in import-repo tests to prevent leaking writes to the real team-repo. --story=1032854480 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isMetadataOnlyDiff()guard inpushRepoBranch— when all staged changes are just timestamp fields (lastUpdated,lastScan,syncedAt), skip branch creation and MR creation entirelyconfig.jsin import-repo tests to prevent leaking writes to the real team-repo when~/.teamai/config.yamlexistsRoot Cause
teamai import --from-repogenerates files with timestamp fields that change every run. This causesgit diffto always report changes, so every execution creates a new MR — even when the actual codebase content hasn't changed. On the HyperAI/teamai TGit repo, this produced 17+ duplicate "Import codebase knowledge" MRs.Test plan
npx tsc --noEmit— no type errorsnpx vitest run src/__tests__/git.test.ts— 26 tests pass (including new metadata-only diff tests)npx vitest run src/__tests__/import-repo-merge.test.ts— 3 tests pass (previously 1 failed due to missing config mock)npx vitest run src/__tests__/import-repo-incremental.test.ts— passes with config isolationnpm run build— build success🤖 Generated with Claude Code