chore(submodule): ignore root deps#4325
Open
liweijie0812 wants to merge 5 commits into
Open
Conversation
liweijie0812
requested review from
HaixingOoO,
NWYLZW,
RylanBot,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
Collaborator
TDesign Component Site Preview Open
|
Contributor
|
Size Change: 0 B Total Size: 87.8 kB ℹ️ View Unchanged
|
commit: |
Contributor
|
Size Change: +56 B (+0.01%) Total Size: 921 kB 📦 View Changed
ℹ️ View Unchanged
|
uyarn
approved these changes
Jul 10, 2026
RylanBot
reviewed
Jul 10, 2026
| "eslint-config-airbnb-base": "^14.2.1", | ||
| "eslint": "^8.57.1", | ||
| "eslint-config-airbnb-base": "^15.0.0", | ||
| "eslint-config-prettier": "^9.1.0", |
Collaborator
There was a problem hiding this comment.
https://github.com/Tencent/tdesign-react/pull/4303/changes#r3496794260
前段时间这个 PR 讨论过...应该不需要 eslint-config-prettier 这个包 🤔？ @RSS1102
Collaborator
Author
There was a problem hiding this comment.
之前从common 子仓带入了,现屏蔽后,没装报错
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
为什么要排除packages/common 顶层依赖
当前存在顶层依赖意外引入 packages/common 的问题，该问题源于仓库改造为 Monorepo 结构后自动带入依赖，原有单仓架构下并不会安装 common 相关依赖。
common 为公共 JS 工具函数共享仓库，自身包含 ESLint 等开发依赖（devDependencies），这类依赖与 UI 仓库业务无关，一旦被带入安装，极易引发依赖版本覆盖冲突。
仓库接入 lock 文件后该弊端进一步凸显：common 内部依赖发生变更时，UI 仓库必须同步更新自身锁文件，维护逻辑不合理。
本次针对性处理：在顶层配置排除 packages/common 依赖，实现两点优化：
ai-core 子仓 也同上
排除子仓依赖后有lint 问题, 原因 依赖被覆盖了
📝 更新日志
tdesign-react
@tdesign-react/chat
☑️ 请求合并前的自查清单