Fix/4629 drawer rotation#4676
Open
thirumani-vihaan wants to merge 2 commits into
Open
Conversation
Fixes: TeamAmaze#4629 The issue occurs when a user navigates to a Drawer Category (like "Images") and rotates the device. After rotation, the view incorrectly resets to the default Home directory. This happens because the MainFragmentViewModel's currentPath is either lost or re-initialized from the original fragment arguments (which contain the Home path) upon recreation. To fix this, I implemented state-saving logic in MainFragment using onSaveInstanceState to explicitly preserve the currentPath and openMode, and restore them in onCreate().
thirumani-vihaan
force-pushed
the
fix/4629-drawer-rotation
branch
from
0c9445b to
d0130b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the device is rotated, the
FragmentStateAdapteraggressively recreatesTabFragment, which subsequently callsupdatePaths(). In non-FILE modes (likeOpenMode.CUSTOMfor Images orOpenMode.RECENTfor Recent Files), this inadvertently overwrote the database with the Home directory. This PR explicitly overridesonSaveInstanceStateinMainFragmentto preserve thecurrentPathandopenMode, ensuring the state is correctly restored when theViewModelis re-initialized post-rotation.Issue tracker
Fixes #4629
Automatic tests
Manual tests
Done
Device: Pixel Emulator
OS: Android 14 (API 34)
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
This PR used generative code tools (GenAI, LLMs, etc.)
Model: Gemini 3.1
Version: 3.1
Provider: Google DeepMind