AKitLog constructor without IPropertySupport#673
Open
Rongrrz wants to merge 1 commit into
Open
Conversation
aschokking
approved these changes
May 22, 2026
| this(parent.getPrefix()); | ||
| } | ||
|
|
||
| public AKitLogger(Object object) { |
Contributor
There was a problem hiding this comment.
What was the situation you wanted this for? Should it instead ask for a string name?
Contributor
Author
There was a problem hiding this comment.
I thought that it was more convenient to make AKitLoggers in situations where the object doesn't have a prefix, where we can just do new AKitLogger(this). However, thinking about it more, this is probably less necessary as the more explicit, already-existing version of new AKitLogger(this.getClass().getName()) also seems more reasonable, though for that one it's a longer line and you'll have to manually append a "/".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Whats changing?
Questions/notes for reviewers
How this was tested