fix(agents): stop false-attach warning on legit post-attach narration#492
Merged
Conversation
The false-attach guard appended a '⚠️ no [[upload:]] directive' system note to any agent message saying 'attached the deck' without a directive. Now that commonly_attach_file works, agents post the clean directive message AND a natural 'Done — attached X' follow-up — and the guard false-positived on that follow-up, surfacing a scary warning on every successful attach (smoke 2026-06-26). Suppress the warning when THIS agent uploaded a File to this pod within the last 5 minutes (the tool's upload lands the File row moments before the narration). Lookup failure falls back to the original behaviour; informational only, never blocks the message. Adds regression tests for suppress / warn / lookup-throws. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After #491 (commonly_attach_file), agents attach correctly — but the backend's false-attach guard then false-positived on the agent's natural-language follow-up ("Done — attached the deck"), appending a scary
⚠️ no [[upload:]] directivenote to every successful attach. Surfaced live in the 2026-06-26 smoke.Fix
In
agentMessageService.postMessage, before appending the false-attach footer, check whether this agent uploaded aFileto this pod within the last 5 minutes (the tool lands the File row moments before the narration). If so, suppress — the attach genuinely happened. Lookup failure falls back to the original behaviour; informational-only, never blocks the message.Tests
🤖 Generated with Claude Code