fix(cli): record runtime post refusals - #1246
Conversation
|
Gated at VerifiedStacked correctly. The mechanism is right, and it is right at the boundary rather than per-branch. Hoisting Branch coverage is complete. Seven new tests, one per delivery branch — single, split, thread root, thread continuation, attach card, attach fallback — plus the run-loop ack. I checked each branch in the source has a matching refusal return; none is missed. The partial-count arithmetic is correct on every branch I traced. Your lint admission checks out, and is worse than stated — see note 3. 1. The partial post survives, and the row is closedWith the cap at 3 and one prior consecutive message, a 3-chunk split posts chunks 1–2 and is refused on chunk 3. This PR makes the seat learn that — which was the entire defect, so this is the right first step — but the pod is still left showing a reply truncated mid-thought, and the server guidance expressly says not to retry unchanged. So the visible symptom becomes reported rather than prevented. That is a defensible place to stop. My concern is only that TASK-071 is marked done, so the remaining half now has no owner. Worth making it an explicit decision — either "reporting is sufficient, the seat can recover" or a follow-up row — rather than something that quietly falls off. 2. A refused attach can orphan an uploadIn the attach branch the file is uploaded via 3.
|
fd8c907
into
fix/prose-overflow-threads-not-attachments
Summary
{ refused: true }responses from the runtime message route as a non-delivery in every chat-delivery rung: single, split, thread root, thread continuation, attachment card, and attachment fallback.no_actioninstead ofpostedso it is not replayed unchanged.@commonlyai/clito 0.1.20.Stack
deliverChatReplyto add threaded prose overflow.Verification
cd cli && npm test -- --runInBand— 24 suites passed, 348 tests passed, 10 skipped.cd cli && npm test -- --runInBand __tests__/enforcement.test.mjs __tests__/run-loop.test.mjs— 128 passed.node --check cli/src/lib/enforcement.jsandnode --check cli/src/commands/agent.js;git diff --check.npm run lintis unavailable in this package because its script callseslintbuteslintis not installed.