docs(agents): cite installedBy's writers by symbol, and stop implying five - #1223
Open
lilyshen0722 wants to merge 3 commits into
Open
docs(agents): cite installedBy's writers by symbol, and stop implying five#1223lilyshen0722 wants to merge 3 commits into
lilyshen0722 wants to merge 3 commits into
Conversation
@sprint-review (57766): after #1166 this is the only `limit: 10` left in agent.js, and the reason it is fine is one function away and invisible here. Anyone who greps the constant after reading that thread has to re-derive the distinction — two identical strings, opposite significance, no local marker. No behaviour change. The events fetch went to 1 because fetching an event CLAIMS it; this endpoint returns pod messages for the echo check and claims nothing, so ten rows cost ten rows. Comment rather than a test because there is no wrong behaviour to pin — the failure mode is a reader's question, and the answer belongs where the question gets asked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… five @sprint-review recounted (57771) and the bot half holds at exactly five. The human half does not: the comment listed five sites as though that were the set, and there are at least ten — podController, authController, personaHireService, podCurationService, agentProfile, registry/install, registry/admin, dmService twice, and one in THIS file, the auto-install inside resolveMentionTarget writing `senderUserId`. Line numbers dropped for symbols, per the rule #1165 earned: a sha 404s and a grep for a symbol fails loudly, but a line number answers wrongly. Five of the six positions this comment cited had already moved. The count itself is now stated as a floor with the grep that reproduces it, because the failure here was not the number being wrong on the day — it was a number frozen into prose where nothing re-derives it. The grep's caveat is included too: it returns queries (agentMemoryView, approvalActionService) and propagations of an existing value, neither of which writes an identity. Re-deriving that distinction is what separated my ten from a larger raw count. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…iled under queries
@sprint-review 57854 pushed the caller-identity half to "9 or more". Re-derived
against `grep -rn 'installedBy:' backend | grep -v __tests__` (43 non-test
occurrences) and separated writes from filters and propagations:
- Bot identity: exactly 5 (agentAutoJoinService, podWriteAccessService,
agentsRuntime ×3) — as written, unchanged.
- Caller identity: 12, not 10. The two this comment missed are
approvalActionService:572 and :660, both `$setOnInsert: { installedBy:
row.ownerUserId }`. The previous draft named that file under queries ONLY —
it does both, and listing it on one side made the other side invisible.
- `agentMemoryView:123` is a query filter, not a write, so it does not join
the human list; the comment already named it as a query and that stands.
The count is now stated as a floor the enumeration reaches, not a census, and
the query/propagation clause names its members so the next reader can tell
which kind each site is without re-running the split.
Comment-only. 62/62 agentMentionService tests green; no tsc errors in this file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comment only. No behaviour change.
@sprint-review recounted the
installedBywriters (57771). The bot half holds at exactly five. The human half doesn't — the comment listed five sites as though that were the set.There are at least ten originating human-side writes:
podController,authController,personaHireService,podCurationService,agentProfile,registry/install,registry/admin,dmService(twice), and one in this very file — the auto-install insideresolveMentionTarget, which writessenderUserId.Two changes
Line numbers → symbols. Per the rule #1165 earned: a sha 404s and a grep for a symbol fails loudly, but a line number answers wrongly. Five of the six positions this comment cited had already moved.
The count is now a floor, with the grep that reproduces it. The failure wasn't the number being wrong on the day it was written — it was a number frozen into prose where nothing re-derives it.
Residue, stated in the comment
grep -rn 'installedBy:' backend | grep -v __tests__also returns queries (agentMemoryView,approvalActionService) and propagations of an existing value. Neither writes an identity. Re-deriving that distinction is what separated the ten from a larger raw count — worth naming, since the next person runs the same grep.Note for whoever merges
Touches the same comment block as #1216, a few lines apart. Non-overlapping hunks, but land them in either order and re-read the block once.
agentMentionServicesuite green,tscclean.🤖 Generated with Claude Code