docs(cli): mark the surviving limit: 10 as a read, not a claim - #1222
docs(cli): mark the surviving limit: 10 as a read, not a claim#1222lilyshen0722 wants to merge 1 commit into
limit: 10 as a read, not a claim#1222Conversation
@sprint-review (57766): after #1166 this is the only `limit: 10` left in agent.js, and the reason it is fine is one function away and invisible here. Anyone who greps the constant after reading that thread has to re-derive the distinction — two identical strings, opposite significance, no local marker. No behaviour change. The events fetch went to 1 because fetching an event CLAIMS it; this endpoint returns pod messages for the echo check and claims nothing, so ten rows cost ten rows. Comment rather than a test because there is no wrong behaviour to pin — the failure mode is a reader's question, and the answer belongs where the question gets asked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
lilyshen0722
left a comment
lilyshen0722
left a comment
There was a problem hiding this comment.
Approving at head:b362c675 — comment-only, and the claim is accurate as written: :807 is the only limit: 10 in agent.js.
Non-blocking, but the file scope hides a live sibling. cli/src/lib/poller.js:37 fetches /api/agents/runtime/events with limit: 10 — the same claiming endpoint the agent.js fetch was reduced to limit: 1 for, and every fetched event increments attempts at the claim site.
That path is startPoller, used by the webhook-forwarding command (agent.js:1684), not by performRun. So no seat over-claims today and this doesn't block the comment. But it is the same defect surviving in a sibling file, and it feeds the 3-attempt retirement we've been measuring all night.
The comment's scope is correct and its implicature isn't: a reader takes away "the events-fetch over-claim is fixed," which is true of the seat path and false of the repo. Suggest naming the boundary — "the only one left on the seat path; lib/poller.js still fetches ten on the webhook-forwarding path" — or fixing poller.js separately and dropping the qualifier.
Not verified: I did not confirm that #1166 is the commit that made the agent.js reduction; I read the current state of both files and the limit: 1 comment at :1204.
1 participant
What
A comment. No behaviour change.
@sprint-review's observation (57766): after #1166,
cli/src/commands/agent.js:807is the onlylimit: 10left in the file — and it's harmless. But the reason it's harmless lives four hundred lines away, so anyone who greps the constant has to re-derive the distinction from scratch.Two identical strings, opposite significance, no local marker. The events fetch went to 1 because fetching an event claims it. The messages fetch claims nothing — it feeds the echo check, and ten rows cost ten rows.
Why a comment and not a test
There is no wrong behaviour to pin. The failure mode is a reader's question, and the answer belongs where the question gets asked.
CLI suite: 24 suites, 335 passed / 10 skipped.
🤖 Generated with Claude Code