Skip to content

Task 3766: Add TDEI register/forgot links to sign-in - #119

Open
shweta2101 wants to merge 3 commits into
developfrom
feature-task-3766-add-recovery-links
Open

Task 3766: Add TDEI register/forgot links to sign-in#119
shweta2101 wants to merge 3 commits into
developfrom
feature-task-3766-add-recovery-links

Conversation

@shweta2101

@shweta2101 shweta2101 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

DevBoard Task

https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3766

Changes Implemented

  • Added Register and Forgot Password links to the Workspaces login form.
  • Links redirect users to the respective TDEI Portal pages.
  • URLs are configured using:
    • VITE_TDEI_REGISTER_URL
    • VITE_TDEI_FORGOT_PASSWORD_URL
  • Added the variables to Docker build arguments, and Playwright configuration.
  • Used existing TDEI theme colors and responsive styling.
  • Added E2E tests and updated the accessibility snapshot.

Impacted Areas for Testing

  • Verify both links appear on the login form.
  • Verify Register opens the configured registration page.
  • Verify Forgot Password opens the configured password-recovery page.
  • Verify URLs are correct in development, staging, and production environments.
  • Verify the login form layout on desktop and mobile.
  • Verify existing sign-in, password visibility, and validation behavior remains unchanged.
  • Verify Docker and deployment builds receive both new environment variables.

Screenshot:

Screenshot 2026-08-27 at 12 38 59 PM

Summary

  • Added Register and Forgot Password links to the sign-in form.
  • Configured the links with VITE_TDEI_REGISTER_URL and VITE_TDEI_FORGOT_PASSWORD_URL.
  • Added Docker build arguments and Playwright environment variables.
  • Added E2E link validation and updated the accessibility snapshot.
  • Added responsive styles for the new links.

Expose VITE_TDEI_REGISTER_URL and VITE_TDEI_FORGOT_PASSWORD_URL across the app and add account links to the sign-in form. Dockerfile ARGs were added, the SigninForm component now reads the env vars, renders register/forgot-password links and styles them, Playwright config seeds the test env with portal-dev URLs, and an e2e test + snapshot were added to verify the links.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 28 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d79dcb6-69a6-441c-a79c-170a3adc4116

📥 Commits

Reviewing files that changed from the base of the PR and between ee1fea3 and 4245247.

📒 Files selected for processing (5)
  • Dockerfile
  • components/SigninForm.vue
  • playwright.config.ts
  • test/e2e/signin.spec.ts
  • test/e2e/signin.spec.ts-snapshots/shows-the-sign-in-form-to-an-unauthenticated-visitor-1.aria.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e086409-957a-4b43-aaaa-6cfefed04052

📥 Commits

Reviewing files that changed from the base of the PR and between 42cbab6 and ee1fea3.

📒 Files selected for processing (5)
  • Dockerfile
  • components/SigninForm.vue
  • playwright.config.ts
  • test/e2e/signin.spec.ts
  • test/e2e/signin.spec.ts-snapshots/shows-the-sign-in-form-to-an-unauthenticated-visitor-1.aria.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The sign-in form now displays configurable registration and password recovery links. Docker and Playwright pass the URLs through build and test environments. E2E coverage verifies link destinations and the updated accessibility snapshot.

Changes

Sign-in account links

Layer / File(s) Summary
URL environment wiring
Dockerfile, components/SigninForm.vue, playwright.config.ts
The builder accepts the two portal URL arguments. The sign-in form reads them from import.meta.env. Playwright supplies test URLs.
Sign-in links and validation
components/SigninForm.vue, test/e2e/signin.spec.ts, test/e2e/signin.spec.ts-snapshots/...
The form renders and styles registration and password recovery links. E2E coverage checks both destinations, and the accessibility snapshot includes the new navigation region.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ee1fe

This localized sign-in change adds configured registration and password-recovery links without any identified correctness, security, availability, or deployment issue. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: jeffmaki

Poem

A rabbit hops where sign-in flows
Two portal paths now softly glow
Register opens a welcoming door
Forgot Password finds the shore
Tests check links from hop to hop

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the addition of TDEI Register and Forgot Password links to the sign-in form. This matches the main change in the pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (3 skipped: 3 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Change account link labels in SigninForm.vue: 'Register' → 'Register Now' and 'Forgot Password' → 'Forgot Password?'. Add CSS to remove link underlines (no text-decoration on normal and hover) while keeping existing color/hover behavior. Update Playwright e2e test and the ARIA snapshot to reflect the new link text.
Replace separate VITE_TDEI_REGISTER_URL and VITE_TDEI_FORGOT_PASSWORD_URL with a single VITE_TDEI_PORTAL_URL. SigninForm now builds register (/register) and forgot password (/ForgotPassword) URLs from the portal base, Playwright e2e env is updated to provide the portal base, and the Dockerfile ARG was renamed to VITE_TDEI_PORTAL_URL for the build environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant