Task 3766: Add TDEI register/forgot links to sign-in - #119
Conversation
Expose VITE_TDEI_REGISTER_URL and VITE_TDEI_FORGOT_PASSWORD_URL across the app and add account links to the sign-in form. Dockerfile ARGs were added, the SigninForm component now reads the env vars, renders register/forgot-password links and styles them, Playwright config seeds the test env with portal-dev URLs, and an e2e test + snapshot were added to verify the links.
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe sign-in form now displays configurable registration and password recovery links. Docker and Playwright pass the URLs through build and test environments. E2E coverage verifies link destinations and the updated accessibility snapshot. ChangesSign-in account links
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized sign-in change adds configured registration and password-recovery links without any identified correctness, security, availability, or deployment issue. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (3 skipped: 3 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change account link labels in SigninForm.vue: 'Register' → 'Register Now' and 'Forgot Password' → 'Forgot Password?'. Add CSS to remove link underlines (no text-decoration on normal and hover) while keeping existing color/hover behavior. Update Playwright e2e test and the ARIA snapshot to reflect the new link text.
Replace separate VITE_TDEI_REGISTER_URL and VITE_TDEI_FORGOT_PASSWORD_URL with a single VITE_TDEI_PORTAL_URL. SigninForm now builds register (/register) and forgot password (/ForgotPassword) URLs from the portal base, Playwright e2e env is updated to provide the portal base, and the Dockerfile ARG was renamed to VITE_TDEI_PORTAL_URL for the build environment.
DevBoard Task
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3766
Changes Implemented
VITE_TDEI_REGISTER_URLVITE_TDEI_FORGOT_PASSWORD_URLImpacted Areas for Testing
Screenshot:
Summary
RegisterandForgot Passwordlinks to the sign-in form.VITE_TDEI_REGISTER_URLandVITE_TDEI_FORGOT_PASSWORD_URL.