Added some tests. - #89
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
shweta2101
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how response headers are handled when proxying API requests, specifically to prevent CORS errors caused by duplicate or conflicting headers. The main change is to strip certain CORS-related headers from upstream responses before forwarding them, ensuring compatibility with the application's own CORS middleware. A new test is also added to verify this behavior.
Response header handling improvements:
STRIP_RESPONSE_HEADERSset inapi/main.pyto include CORS-related headers (such asaccess-control-allow-originandvary) in addition to hop-by-hop headers, preventing them from being forwarded from upstream responses.capabilitiesandcatch_allendpoints inapi/main.pyto useSTRIP_RESPONSE_HEADERSinstead of justHOP_BY_HOP_HEADERS, ensuring that problematic headers are stripped. [1] [2]Testing improvements:
test_upstream_cors_headers_are_strippedintests/integration/test_proxy.pyto verify that CORS-related headers from upstream (such asaccess-control-allow-originandvary) are correctly removed from responses.