Add SF graph polygon layers to Mapbox map#1
Open
darithedev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for displaying and interacting with building entrances on the map, including visualizing entrance points, handling user selection, and showing detailed entrance metadata. It also adds a new utility module for parsing and normalizing entrance data and a JSON schema for entrance records. The changes improve the user experience by allowing users to select entrances directly from the map, see relevant metadata, and ensure consistent entrance data handling.
Map display and interaction enhancements:
App.jsxto visualize building polygons and entrances, including custom styling for entrance types and buildings. Entrances are loaded asynchronously from a GeoJSON file using the newloadEntrancesutility.Entrance data processing utilities:
entrances.jsmodule with functions to parse OSM node IDs, normalize entrance features, generate human-readable descriptions, and load/convert entrance GeoJSON data for Mapbox.UI improvements for entrance metadata:
PointMetacomponent to display detailed entrance metadata (type, wheelchair access, door type, etc.) when an entrance is selected, instead of just coordinates.Data validation:
entrance.schema.json) to define and validate the structure of entrance records, ensuring data consistency.How to Test
Prerequisites
/data/ca.sanfrancisco.graph.polygons.geojson/data/sf.entrances.geojsonTest Steps
/data/ca.sanfrancisco.graph.polygons.geojson/data/sf.entrances.geojson