fix: v2 - rectangle selection of one node#2195
Open
maxy-shpfy wants to merge 1 commit into05-01-fix_v2_-_proper_undo_for_del_action_on_canvasfrom
Open
fix: v2 - rectangle selection of one node#2195maxy-shpfy wants to merge 1 commit into05-01-fix_v2_-_proper_undo_for_del_action_on_canvasfrom
maxy-shpfy wants to merge 1 commit into05-01-fix_v2_-_proper_undo_for_del_action_on_canvasfrom
Conversation
🎩 PreviewA preview build has been created at: |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
This was referenced May 4, 2026
camielvs
approved these changes
May 4, 2026
maxy-shpfy
force-pushed
the
05-01-fix_v2_-_proper_undo_for_del_action_on_canvas
branch
from
5a1f6ef to
4b8814b
Compare
maxy-shpfy
force-pushed
the
05-03-fix_v2_-_rectangle_selection_of_one_node
branch
from
7fa01d0 to
925dda5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a single node is selected in the editor,
selectNodeis now explicitly called with the node'sidandtype. Previously, single-node selections only cleared the multi-selection state without triggeringselectNode, which could leave the editor in an inconsistent selection state.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Before:
Screen Recording 2026-05-03 at 4.30.30 PM.mov (uploaded via Graphite)
After:
Screen Recording 2026-05-03 at 4.31.19 PM.mov (uploaded via Graphite)
Test Instructions
Additional Comments