chore: v2: Improve Simplified Nodes#2178
Open
camielvs wants to merge 1 commit into04-28-feat_v2_migrate_collapsible_nodes_to_v2_editorfrom
Open
chore: v2: Improve Simplified Nodes#2178camielvs wants to merge 1 commit into04-28-feat_v2_migrate_collapsible_nodes_to_v2_editorfrom
camielvs wants to merge 1 commit into04-28-feat_v2_migrate_collapsible_nodes_to_v2_editorfrom
Conversation
🎩 PreviewA preview build has been created at: |
3 tasks
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
camielvs
force-pushed
the
04-28-chore_v2_improve_simplified_nodes
branch
8 times, most recently
from
176ebde to
4499150
Compare
camielvs
force-pushed
the
04-28-chore_v2_improve_simplified_nodes
branch
2 times, most recently
from
4791d40 to
d87edb0
Compare
camielvs
force-pushed
the
04-28-feat_v2_migrate_collapsible_nodes_to_v2_editor
branch
from
c65a422 to
dd0c59c
Compare
camielvs
force-pushed
the
04-28-chore_v2_improve_simplified_nodes
branch
from
d87edb0 to
2976bfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a couple of small improvements to the zoomed-out node state to make it a little nicer to look at and work with.
Namely:
These changes do not affect v1 editor - only v2.
Also adds a shared utility
useIsDetailedView.Related Issue and Pull requests
Resolves https://github.com/Shopify/oasis-frontend/issues/600
Type of Change
Checklist
Screenshots (if applicable)
before
after
Test Instructions
Open v2 editor with a variety of nodes.
Zoom out.
If you like the way it looks, approve the PR :)
Additional Comments