Skip to content

Adds inline rename for pipelines and tasks#2150

Merged
Mbeaulne merged 2 commits intomasterfrom
04-23-rename_pipeline_and_task_nodes
May 1, 2026
Merged

Adds inline rename for pipelines and tasks#2150
Mbeaulne merged 2 commits intomasterfrom
04-23-rename_pipeline_and_task_nodes

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Apr 23, 2026

Description

Adds inline rename functionality for both pipelines and tasks in the editor.

For pipelines, a pencil icon appears next to the pipeline name in the menu bar on hover. Clicking it opens a PipelineNameDialog that allows the user to rename the pipeline, update the file, and navigate to the new route.

For tasks, a pencil icon appears next to the task name in the TaskDetails panel on hover. Clicking it replaces the name with an inline Input field. The rename is committed on blur or Enter, and cancelled on Escape.

Related Issue and Pull requests

Resolves #31

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

image.png

Test Instructions

  1. Open a pipeline in the editor.
  2. Hover over the pipeline name in the menu bar — a pencil icon should appear.
  3. Click the pencil icon, enter a new name, and confirm — the pipeline should be renamed and the route updated.
  4. Open a task's detail panel by clicking a task node.
  5. Hover over the task name — a pencil icon should appear.
  6. Click the pencil icon and edit the name inline. Press Enter or click away to confirm, or press Escape to cancel.

Additional Comments

@Mbeaulne Mbeaulne marked this pull request as ready for review April 23, 2026 16:17
@Mbeaulne Mbeaulne requested a review from a team as a code owner April 23, 2026 16:17
@Mbeaulne Mbeaulne changed the title rename pipeline and task nodes Adds inline rename for pipelines and tasks Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🎩 Preview

A preview build has been created at: 04-23-rename_pipeline_and_task_nodes/fcfc5c0

@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 9442648 to 4b08166 Compare April 23, 2026 16:39
Comment thread src/routes/v2/pages/Editor/components/EditorMenuBar/EditorMenuBar.tsx Outdated
Comment thread src/routes/v2/pages/Editor/nodes/TaskNode/context/TaskDetails/TaskDetails.tsx Outdated
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 4b08166 to b43b7db Compare April 23, 2026 18:59
size="sm"
weight="semibold"
className="text-white truncate max-w-64 lg:max-w-md leading-tight ml-1"
<InlineStack
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: name is no longer vertically centred on the color picker
image.png

Copy link
Copy Markdown
Collaborator Author

@Mbeaulne Mbeaulne Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This is an AI-generated response.

Fixed — the rename button (raw <button>) had default browser padding which made the title row taller than just the text, throwing off vertical alignment. Added p-0 flex items-center to compact it down to the icon's natural size.

_________

Edit:

👨 This is a HUMAN-generated response.

I've converted button to the primitive.

Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i rename a pipeline the page header does not update.

image.png

iirc this might have been fixed on master if you haven't rebased recently

@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from b43b7db to 392d8b8 Compare April 28, 2026 16:12
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 974a715 to 2e7e47b Compare April 28, 2026 16:12
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 392d8b8 to e8ed98e Compare April 28, 2026 16:15
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch 2 times, most recently from c6cf5b0 to 7b069e8 Compare April 28, 2026 16:53
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch 2 times, most recently from 3b7778c to 1968ace Compare April 28, 2026 17:15
@Mbeaulne Mbeaulne requested a review from camielvs April 28, 2026 17:15
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 7b069e8 to cb453a4 Compare April 28, 2026 20:15
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 1968ace to 3b86ac3 Compare April 28, 2026 20:16
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from cb453a4 to 6a6f4c7 Compare April 28, 2026 20:23
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 3b86ac3 to 184387f Compare April 28, 2026 20:24
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could treat this as a separate, preexisting, bug:

I can rename a pipeline (pipeline -> pipeline2). The name & url are updated.

I can then undo. The name is updated (pipeline2 -> pipeline), but not the url.
Now, everywhere else I go (e.g. pipeline dashboard) the renamed name will show (pipeline 2). When I open the pipeline it takes me to the renamed url (/pipeline2) but with the undone name (pipeline).
If I then rename the pipeline again (-> pipeline3) the url is updated but not the name. In v1 editor the correct name is shown, but in v2 it still shows pipeline rather than pipeline3

In other words, undo-redo is causing sync/state issues with pipeline renaming.

@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 6a6f4c7 to f278ba1 Compare April 30, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 184387f to 9bb57ed Compare April 30, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch 2 times, most recently from 8dc0276 to 9dc13a7 Compare April 30, 2026 20:00
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 9bb57ed to 5900b84 Compare April 30, 2026 20:00
Copy link
Copy Markdown
Collaborator

Screen Recording 2026-04-30 at 2.21.51 PM.mov (uploaded via Graphite)

^ small UX note - "edit" is much less in width compared to the original title - maybe can be set to w-full?

@Mbeaulne Mbeaulne force-pushed the 04-23-move_actions_to_menu branch from 9dc13a7 to b8d8d70 Compare April 30, 2026 21:41
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 5900b84 to 9b621f3 Compare April 30, 2026 21:41
@Mbeaulne Mbeaulne changed the base branch from 04-23-move_actions_to_menu to graphite-base/2150 May 1, 2026 20:10
@Mbeaulne Mbeaulne force-pushed the graphite-base/2150 branch from b8d8d70 to 9df327b Compare May 1, 2026 20:13
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from 9b621f3 to a6bc1c0 Compare May 1, 2026 20:13
@graphite-app graphite-app Bot changed the base branch from graphite-base/2150 to master May 1, 2026 20:14
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Mbeaulne Mbeaulne force-pushed the 04-23-rename_pipeline_and_task_nodes branch from a6bc1c0 to fcfc5c0 Compare May 1, 2026 20:14
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented May 1, 2026

Merge activity

  • May 1, 8:18 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 1, 8:18 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne merged commit 307b65e into master May 1, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 04-23-rename_pipeline_and_task_nodes branch May 1, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Pipeline Editor - Allow editing pipeline/graph name, description, annotations

3 participants