Skip to content

refactor: remove sidebar in favor of simple approach#1787

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-11-refactor_remove_sidebar_in_favor_of_simple_approach
Feb 19, 2026
Merged

refactor: remove sidebar in favor of simple approach#1787
maxy-shpfy merged 1 commit intomasterfrom
02-11-refactor_remove_sidebar_in_favor_of_simple_approach

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 11, 2026

Description

Removed the sidebar provider and refactored the flow sidebar to use a simpler, more direct approach. The new implementation:

  • Eliminates the complex sidebar context and provider system
  • Replaces the multi-level sidebar components with a cleaner, more focused implementation
  • Improves the sidebar UI with consistent styling and better component organization
  • Extracts action buttons into separate components for better maintainability
  • Maintains all existing functionality while reducing code complexity
Before After
image.png
image.png

Type of Change

  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-02-11 at 11.00.23 AM.mov (uploaded via Graphite)

  1. Open the pipeline editor
  2. Verify the sidebar displays correctly with all sections (Pipeline Actions, Runs & Submissions, Components)
  3. Test all sidebar actions (save, save as, import, export)
  4. Verify component search and drag-and-drop functionality works as expected
  5. Check that the resize handle works properly

Note

I removed "collapse" feature for the left side bar, since I'm not yet convinced it is useful, but I plan to re-introduce it in a follow up PR to keep it focused.

Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 11, 2026

@maxy-shpfy maxy-shpfy force-pushed the 02-11-refactor_remove_sidebar_in_favor_of_simple_approach branch from 8a28a97 to b7d4561 Compare February 11, 2026 18:47
@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 11, 2026 19:01
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 11, 2026 19:01
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Great simplification and refactoring.

Only comment is that the new sidebar appears to be horizontally scrollable within its container (seemingly only when the component library is fully collapsed)

image.png

@maxy-shpfy maxy-shpfy force-pushed the 02-11-refactor_remove_sidebar_in_favor_of_simple_approach branch from b7d4561 to 86da5be Compare February 19, 2026 03:21
@maxy-shpfy maxy-shpfy force-pushed the 02-10-feat_resizable_left_side_bar branch from a712911 to b83a0d9 Compare February 19, 2026 03:21
Copy link
Copy Markdown
Collaborator Author

@camielvs ^ fixed!

@maxy-shpfy maxy-shpfy requested a review from camielvs February 19, 2026 03:22
@maxy-shpfy maxy-shpfy changed the base branch from 02-10-feat_resizable_left_side_bar to graphite-base/1787 February 19, 2026 18:33
@maxy-shpfy maxy-shpfy force-pushed the 02-11-refactor_remove_sidebar_in_favor_of_simple_approach branch from 86da5be to c7a9b3a Compare February 19, 2026 18:37
@graphite-app graphite-app Bot changed the base branch from graphite-base/1787 to master February 19, 2026 18:37
@maxy-shpfy maxy-shpfy force-pushed the 02-11-refactor_remove_sidebar_in_favor_of_simple_approach branch from c7a9b3a to f208793 Compare February 19, 2026 18:38
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 19, 2026

Merge activity

  • Feb 19, 6:45 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 6:45 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit 1e88d7a into master Feb 19, 2026
7 of 8 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-11-refactor_remove_sidebar_in_favor_of_simple_approach branch February 19, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants