Repository navigation
fix(docs): Allow square brackets in repo paths for dynamic routes - #1273
sentry[bot] wants to merge 2 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 7f96347 | Commit Preview URL Branch Preview URL |
Sep 14 2026, 11:05 PM |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This bracket-path fix already shipped in #1288 (a9c6ee7), including regression coverage. I also ran the exact +page.svelte path from this PR against the current validator and it passes; traversal, empty path segments, and query delimiters are still rejected. Closing this duplicate. #1238 additionally allows route-group parentheses, which is a separate change and remains open. |
This PR addresses an issue where SvelteKit and Next.js dynamic route filenames, which use square brackets (e.g.,
[postId]), were being rejected by theisValidRepoPathvalidation.The
REPO_PATH_SEGMENT_PATTERNregex insrc/utils/repo-path.tsdid not include[or], leading to a validation error when the example viewer attempted to load source files likeexamples/svelte/ssr/src/routes/[postId]/+page.svelte.Changes Made:
REPO_PATH_SEGMENT_PATTERNinsrc/utils/repo-path.tsto include[and]characters.tests/repo-path.test.tsto specifically validate paths containing square-bracket segments, ensuring the fix works as expected and preventing regressions.This change is safe as existing path traversal defenses remain intact, and it aligns with the precedent of allowing other special characters like
$in repo paths.Fixes TANSTACK-COM-2Q9
This PR was automatically generated by Sentry. You can adjust this setting at any time.