fix: reset pending state after leading-only debouncer execution#234
Open
Don-Erfan wants to merge 1 commit into
Open
fix: reset pending state after leading-only debouncer execution#234Don-Erfan wants to merge 1 commit into
Don-Erfan wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughUpdated both debouncer implementations so leading-edge calls are not re-executed by trailing execution or ChangesDebouncer leading-edge behavior
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With leading: true and trailing: true, a single call to maybeExecute executed on the leading edge but still set isPending: true and stored lastArgs. The trailing timeout correctly skips calls already handled by the leading edge, so nothing ever reset that state: status stayed 'pending' forever and a later flush() re-executed the function with stale, already-executed arguments.
Only set isPending/lastArgs for calls not consumed by the leading edge. Apply the same fix to LiteDebouncer, which stored lastArgs unconditionally and could re-execute a leading-edge call via flush().
🎯 Changes
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
flush()behavior so it no longer re-executes an already completed leading-edge call.Tests
flush(), pending state, and idle transitions.