Skip to content

fix(form-core): use equals() for value-type equality (Temporal, Decimal.js) #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixelburg wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

fix(form-core): use equals() for value-type equality (Temporal, Decimal.js) #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/form-core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,13 @@ export function evaluate<T>(objA: T, objB: T) {
return objA.getTime() === objB.getTime()
}

if (
typeof (objA as any).equals === 'function' &&
objA.constructor === objB.constructor
) {
return (objA as any).equals(objB)
}

if (objA instanceof Map && objB instanceof Map) {
if (objA.size !== objB.size) return false
for (const [k, v] of objA) {
Expand Down
12 changes: 12 additions & 0 deletions packages/form-core/tests/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,18 @@ describe('evaluate', () => {
expect(dateObjectFalse).toEqual(false)
})

it('should test equality for objects with an equals() method (e.g. Temporal, Decimal.js)', () => {
class ValueType {
constructor(private val: number) {}
equals(other: ValueType) {
return this.val === other.val
}
}

expect(evaluate(new ValueType(1), new ValueType(1))).toEqual(true)
expect(evaluate(new ValueType(1), new ValueType(2))).toEqual(false)
})

it('should test equality between Map objects', () => {
const map1 = new Map([
['a', 1],
Expand Down