docs: document query cancellation semantics#1692
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds documentation for forwarding ChangesQuery cancellation documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing in favor of #1694, which corrects the cancellation semantics and expands the documentation coverage. Thanks for carrying this forward. |
🎯 Changes
QueryFunctionContext.signalto abortable request clientsCloses #350
✅ Checklist
pnpm test.Additional verification:
pnpm test:docspnpm exec prettier --check docs/collections/query-collection.mdpnpm lintpnpm test:sherifpnpm buildpnpm --filter @tanstack/query-db-collection test🚀 Release Impact
Summary by CodeRabbit
QueryFunctionContext.signal.