feat(QTDI-1291): support guess schema as service - #1220
Open
ozhelezniak-talend wants to merge 2 commits into
Open
feat(QTDI-1291): support guess schema as service#1220ozhelezniak-talend wants to merge 2 commits into
ozhelezniak-talend wants to merge 2 commits into
Conversation
ozhelezniak-talend
changed the title
ozhelezniak-talend
changed the title
ozhelezniak-talend
force-pushed
the
ozhelezniak/QTDI-1291_discoverschema_as_service_v2
branch
2 times, most recently
from
June 15, 2026 09:20
dc85e41 to
32db9eb
Compare
ozhelezniak-talend
force-pushed
the
ozhelezniak/QTDI-1291_discoverschema_as_service_v2
branch
from
June 22, 2026 12:03
c5ddc35 to
c983d31
Compare
ozhelezniak-talend
marked this pull request as ready for review
June 24, 2026 07:43
ozhelezniak-talend
changed the title
undx
reviewed
Jun 24, 2026
undx
left a comment
undx
left a comment
Member
There was a problem hiding this comment.
Please add tests in ActionResourceImplTest for server side changes.
Comment on lines
+31
to
+32
| private String subCode; | ||
|
|
Member
There was a problem hiding this comment.
We've a model change, we need to specify it in jira issue (pinging @acatoire) but, apparently, it doesn't affect TCOMP-api-test.
Contributor
There was a problem hiding this comment.
If the API test does not fail, this mean that this part was not covered or the test was not strict enough, to be checked.
Contributor
Author
There was a problem hiding this comment.
Hello @lxia-talend
Could you handle that part?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates schema discovery to better support “guess schema as a service”, shifting DI-side schema guessing away from action-based invocation, and enhancing component-server error and metadata handling to better distinguish schema parameters and expose richer schema-guess failure info to clients.
Changes:
- Simplify
TaCoKitGuessSchema(DI) to focus on schema discovery through component execution results/lifecycle, and update associated tests. - Add a
definition::parameter::schemametadata marker inPropertiesServiceto identifySchema-typed action parameters. - Extend server error payloads with an optional
subCodeand attempt to surfaceDiscoverSchemaExceptionhandling details to clients.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java | Removes action-based guessing entry points; adds lifecycle-based schema discovery method and simplifies flow. |
| component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java | Updates tests to match the new guessing entry points and expected behavior. |
| component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TypeConversionTest.java | Updates constructor usage after TaCoKitGuessSchema signature changes. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/service/PropertiesService.java | Refactors property-building logic and adds schema-parameter metadata marker. |
| component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ActionResourceImpl.java | Adds DiscoverSchemaException handling and attempts to return richer error info (subCode). |
| component-server-parent/component-server-model/src/main/java/org/talend/sdk/component/server/front/model/error/ErrorPayload.java | Adds subCode field and a compatibility constructor for existing call sites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ozhelezniak-talend
force-pushed
the
ozhelezniak/QTDI-1291_discoverschema_as_service_v2
branch
3 times, most recently
from
June 25, 2026 13:23
2f159f8 to
12af59b
Compare
ozhelezniak-talend
force-pushed
the
ozhelezniak/QTDI-1291_discoverschema_as_service_v2
branch
from
July 7, 2026 11:47
12af59b to
6920ac5
Compare
ozhelezniak-talend
force-pushed
the
ozhelezniak/QTDI-1291_discoverschema_as_service_v2
branch
from
July 9, 2026 09:28
2b2dbf5 to
6840ded
Compare
* cover old functionality in actionresourceimpltests
ozhelezniak-talend
force-pushed
the
ozhelezniak/QTDI-1291_discoverschema_as_service_v2
branch
from
July 28, 2026 09:49
6840ded to
27971e9
Compare
undx
approved these changes
Aug 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code