Skip to content

Fix PostgreSQL visual query follow-ups - #588

Open
DhruvShah-Dev wants to merge 4 commits into
TabularisDB:mainfrom
DhruvShah-Dev:fix-postgres-vqb-followups
Open

Fix PostgreSQL visual query follow-ups#588
DhruvShah-Dev wants to merge 4 commits into
TabularisDB:mainfrom
DhruvShah-Dev:fix-postgres-vqb-followups

Conversation

@DhruvShah-Dev

@DhruvShah-Dev DhruvShah-Dev commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route generateTableList through the same PostgreSQL table reference formatter used by FROM generation
  • format HAVING column references with the existing generated-column formatter
  • quote PostgreSQL SELECT aliases when they need quoting
  • apply PostgreSQL identifier formatting for both postgres and postgresql driver ids

Testing

  • pnpm.cmd exec vitest run tests/utils/visualQuery.test.ts --pool=threads --maxWorkers=1
  • pnpm.cmd exec vitest run tests/utils/visualQuery.test.ts tests/utils/identifiers.test.ts --pool=threads --maxWorkers=1
  • pnpm.cmd typecheck
  • pnpm.cmd lint

@kilo-code-bot

kilo-code-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • src/utils/identifiers.ts
  • src/utils/visualQuery.ts
  • tests/utils/identifiers.test.ts
  • tests/utils/visualQuery.test.ts

Reviewed by ling-3.0-flash-free · Input: 69.6K · Output: 21.3K · Cached: 995.7K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant