fix: support parameters in explain plan - #580
Merged
Merged
Conversation
editor.explain does not exist in any locale, so the params modal submit button rendered the raw key. Reuse editor.visualExplain.buttonShort, already translated in all locales.
Collaborator
|
Thanks @DhruvShah-Dev, great work! Reusing the run flow's parameter handling for Explain Plan is exactly the right approach, and saving the submitted values back to the tab makes the two flows consistent. I pushed one small fix on top: the submit button used Verified locally against MySQL: a parameterized query that previously failed EXPLAIN with ERROR 1064 now prompts for values and opens the plan correctly. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm.cmd typecheckpnpm.cmd lintFixes #565