Archive/pr 2 before official identity 2026 07 20 - #6
Closed
Robbyfuu wants to merge 7 commits into
Closed
Conversation
The Tabularis host is gaining URI passthrough for plugin drivers (TabularisDB/tabularis#495): a driver that declares `connection_uri` receives the raw connection string verbatim on `ConnectionParams` instead of decomposed host/port fields, with the string stored in the OS keychain on the host side. Declare the capability plus the `mongodb` and `mongodb+srv` schemes. `build_uri` already prioritizes `connection_uri` over decomposed fields, so no runtime change is needed; a test now pins that exact key as the wire contract. `connection_string_example` is deliberately left out: on hosts without the passthrough feature, an example would register the `mongodb+srv` protocol and the URI would parse but be decomposed, silently persisting a connection that fails at DNS resolution. Omitting it keeps those hosts at the current loud validation error, while hosts with passthrough register the schemes from `connection_uri_schemes` directly.
The mongodb-atlas id collides with existing MongoDB plugin naming in the ecosystem. The new id describes the actual differentiator — connecting with a full connection URI — rather than a vendor. Bump to 0.2.0 since the id change means existing installs must reinstall under the new directory.
Multi-database drivers receive 'database' as an array from the host, and the strict string check rejected it with "Parameter 'database' must be a string" before the connection URI was even used. Accept string, array (first entry wins), or null in both the request handler and the decomposed-URI builder.
Multi-database navigation sends the selected database in the request's 'schema' field; the plugin only ever looked at the connection-level database, so every request was served from the first stored database and collections came back with schema: null, which the host could not associate with the database the user expanded. The request-level value now outranks the connection default, and collection listings echo the database they belong to.
The host quotes table names when it builds browsing queries (SELECT * FROM "plans"), and the quotes were kept as part of the collection name, so every table view queried a nonexistent collection and came back empty.
Collaborator
Author
|
Closing as superseded by #2. The current main branch already contains the Atlas/full-URI support, and subsequent #3/#4 changes migrated the plugin contract to .tabularium. Rebasing this archival branch would reintroduce the retired manifest.json/release identity. There are no unresolved review threads or failed checks on this PR; preserving the archive branch unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.