fix: 修复 Hytale 等平台适配正确性#716
Open
zhibeigg wants to merge 1 commit into
Open
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原有问题
Hytale 及其他平台适配层中存在阻塞等待、调度语义错误和平台对象包装不一致:
SimpleCommand空树或只有父节点时执行行为不一致。典型触发场景与后果
本 PR 修改
onQuit回调。SimpleCommand空树和父节点执行逻辑。修改目的
让平台抽象忠实反映各平台真实线程、命令、事件和对象语义,避免阻塞平台线程、类型包装错误及边界输入导致的崩溃。
兼容性与行为变化
验证
./gradlew :common-platform-api:test :platform:platform-bukkit-impl:test :platform:platform-bungee-impl:test :platform:platform-velocity-impl:test :platform:platform-hytale:test --rerun-tasks --no-parallel./gradlew :common-platform-api:build :platform:platform-bukkit-impl:build :platform:platform-bungee-impl:build :platform:platform-velocity-impl:build :platform:platform-hytale:build --rerun-tasks --no-parallelgit diff --checkFuture.get、.join()、Thread.sleep或CountDownLatchRefs #703