Skip to content

refactor(datagrid): extract PendingChanges value type from DataChangeManager #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 6 commits into from
Apr 28, 2026
Merged

refactor(datagrid): extract PendingChanges value type from DataChangeManager #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
734733c
refactor(datagrid): extract PendingChanges value type from DataChange…
datlechin Apr 28, 2026
86dfe47
refactor(datagrid): address PendingChanges review feedback
datlechin Apr 28, 2026
9eca620
fix(datagrid): undo replay paths now mark affected rows as changed
datlechin Apr 28, 2026
d7de4e9
fix(datagrid): preserve original DB value through redo so next undo c…
datlechin Apr 28, 2026
1fda7fe
Merge branch 'main' into refactor/datagrid-phase4b-pending-changes
datlechin Apr 28, 2026
e9704c7
fix(datagrid): apply PendingChanges review fixes
datlechin Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- DataChangeManager extracted a PendingChanges value type that owns cross-collection invariants for cell edits, row insertions, and deletions. DataChangeManager kept undo/redo registration, plugin SQL generation, and the `@Observable` boundary, dropping from ~960 to ~190 lines. The serialization DTO `TabPendingChanges` is renamed to `TabChangeSnapshot` to distinguish it from the live tracker.
- AnyChangeManager uses ChangeManaging protocol instead of closure-based type erasure, removing all runtime `[Any]` downcasts
- Row selection state moved from MainContentView @State to GridSelectionState @Observable class, preventing full view tree invalidation on every row click
- QueryTab decomposed into focused sub-types: TabExecutionState, TabTableContext, TabQueryContent, TabDisplayState
Expand Down
Loading
Loading