fix(settings): name Command-[ Outdent and Command-] Indent to match the editor - #3065
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SQL editor maps
Cmd+[to outdent andCmd+]to indent (EditorKeyCommand), the Xcode convention. The shortcut registry that Settings > Keyboard reads named them the other way round, so trying to bindCmd+[to another action was refused as taking "Indent", anddocs/features/keyboard-shortcuts.mdxtold readersCmd+[indents.Found while investigating #2524.
Change
ShortcutAction.editorBuiltIns:Cmd+[is Outdent,Cmd+]is Indent.keyboard-shortcuts.mdx: the opening sentence, the same-key table and the text-editing table follow the editor.Tests
EditorBuiltInNameTestsasserts the names the reserved-shortcut check returns for both chords, run with the neighbouring shortcut suites.