fix(plugins): add the etcd and Kafka strings to the app catalog - #3034
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo Hygiene is red on
main. TheCheck plugin strings reach the string catalogstep fails:26 plugin strings reached
mainwithout reachingTablePro/Resources/Localizable.xcstrings: 5 from the etcd fault rewrite in #3011, and 21 from the Kafka broker routing work in #3023. Neither PR ranpython3 scripts/localization.py plugins, and nothing outside Repo Hygiene does, so both went green locally and red on merge.This is the generated fix:
python3 scripts/localization.py plugins --add, nothing hand-edited. A 78-line append with no reordering or reformatting of the existing catalog.It covers both changes rather than only the etcd half, because the guard is one step and fixing half of it leaves
mainexactly as red. The entries land untranslated, which is what--addis for; translation is a separate pass.Verified
Run on a clean worktree off
origin/main, so the shared checkout's in-flight edits could not contaminate the result.No CHANGELOG entry: both changes that introduced the strings are themselves still unreleased.