Conversation
Member
Author
|
Superseded by #3003, which landed the same assertion change first. Closing as a duplicate; main is green on OracleObjectQueryTests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis red. #2999 qualified every Oracle dictionary view at SQL level, soOracleObjectQueries.triggerListnow readsFROM SYS.ALL_TRIGGERS, buttriggerListSelectsActionTypestill expects the unqualifiedFROM ALL_TRIGGERSand fails on every run.The source is right and the assertion is stale, so the assertion moves to the qualified name. The rest of the case is unchanged: it still pins
ACTION_TYPEbeing selected andTRIGGER_BODYstaying last, which is the reason the test exists (TRIGGER_BODYis a LONG, so a column after it cannot be read).Verification
OracleObjectQueryTests: 17 executed, 17 passed.Filtering that suite by its test function name matches nothing and still reports success, which is how this stayed hidden locally; the run above filters by the suite.