feat: note the Claude subscription tradeoffs and translate the remaining strings - #2020
Merged
datlechin merged 3 commits intoAug 5, 2026
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
datlechin
deleted the
feat/claude-subscription-tradeoffs-and-translations
branch
August 5, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pieces of housekeeping from one session, one commit each.
Translate the strings that still showed in English
442 keys in the Mac catalog carried no
tr,vi,zh-Hans, orzh-Hantat all, and 20 keys in the iOS catalog carried none of the three languages it ships. Both catalogs now cover every translatable key.Terminology follows what the catalogs already use (
Sütun/Cột/列/欄位for column,Eklenti/Plugin/插件/外掛,Salt okunur/Chỉ đọc/只读/唯讀). Technical terms stay in English per CLAUDE.md:COMMENT,(NULL),%@_name,Application Default Credentials,Kerberos Principal,Cloud SQL Auth Proxy, and the plan namesStarterandTeam. The 20 iOS strings that also exist on Mac reuse the Mac wording verbatim, so the two apps read the same.Every translation was checked against its source key for format specifiers: same specifier types, and positional markers whenever a key carries two or more. Turkish reorders arguments in several strings (
%2$lld ifadeden %1$lld tanesi uygulandı), which is exactly why those need positions.The catalogs were rewritten with a serializer that reproduces Xcode's formatting byte for byte, verified by round-tripping both files before any edit, so the diff is only the added localizations. Key order still matches
localizedStandardCompare, which is what Xcode sorts by.This commit also carries 10
extractionStateflag flips that were already in the working tree from Xcode's own extraction. Translations on those entries are untouched.Show the tradeoffs of running chat on a Claude subscription
The Claude Agent provider runs Anthropic's
claudebinary with your Claude Code login. The settings sheet said it "bills against your Claude subscription" and left it there. Whether your subscription's terms allow another app to drive that CLI as a chat backend is a question only Anthropic's terms and the user can answer, and the sheet gave them nothing to answer it with.ClaudeAgentDisclosurenow carries five notes, rendered as a Tradeoffs section under the status row, two cautions first and three details after:claudein headless mode. Claude Code is built for you to use directly, not as a backend for other apps, so this path can break with any Claude Code release.ANTHROPIC_API_KEYandANTHROPIC_AUTH_TOKENare removed from the tool's environment, so replies always draw on the subscription.The last one was the least visible and the most worth saying:
ClaudeAgentCLIstrips both variables so the CLI cannot fall back to API billing.ignoredAPIKeyNoteMatchesBehaviourasserts the note and the environment stripping stay in sync, so the copy cannot drift from the code.The footer points at the metered alternative, the Claude provider with an API key. The provider is not gated behind an acknowledgement and the stripping is unchanged; both are behaviour changes beyond disclosure.
The notes live in
Core/AI/ClaudeAgent/and render through a smallClaudeAgentDisclosureSection, which keepsAIProviderDetailSheet(999 lines, near the 1200 warning) from growing.Simplify the unreleased changelog entries
Same 15 entries, same reference IDs, shorter lines. The restated tails, the five-item list of New Connection entry points, and the duplicated explanations are gone. Numbers that carry the behaviour change stay (the MCP export 50,000 to 500 drop).
Verification
-skipPackagePluginValidationswiftlint lint --strict, project wideClaudeAgentDisclosureTests,ClaudeAgentCLITests,ClaudeAgentRegistrationTestsThe Tradeoffs section itself has not been looked at in a running app; it is a static
SectionofLabelrows in an existingForm.