[Backport 13.4] adjust headlines preceeding confval blocks - #1802
Merged
Conversation
* resolves #1791 for QA check the rendering with a docker image made from main branch of https://github.com/TYPO3-Documentation/render-guides * Fix anchor placement and add rubrics for indented confvals Anchors were left after their heading instead of before it, and with two blank lines instead of one. Some of these anchors also ended up misattached to a different, already-anchored heading (mostly the "Examples" sections) and had to be moved back to the heading they actually belong to. Wherever a confval is indented as part of a parent confval-menu/confval directive, a plain heading breaks that nesting, since sections aren't allowed inside a directive body. Those headings are replaced with an indented `.. rubric::` directive instead - it renders the same visual label without creating a section. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Lina Wolf --------- Signed-off-by: Lina Wolf Co-authored-by: Lina Wolf <> (cherry picked from commit 231c13c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1793 to
13.4.Manual cherry-pick — the automatic backport failed on conflicts in four
files, because 13.4 has diverged from
main. Resolved as follows:PageTsconfig/Mod/WebLayout/BackendLayout.rst: dropped theallowedContentTypes/disallowedContentTypesconfvals(
versionadded:: 14.1, not present on 13.4).PageTsconfig/Mod/Wizards.rst: kept the 13.4-onlyversionchanged:: 13.0note and the[group].showconfval (bothremoved on
main), and gave[group].showa rubric forconsistency. Dropped the
before/afterconfvals(
versionadded:: 14.2) but kept the[group].removeItemsrubric,since that confval does exist on 13.4.
TopLevelObjects/Config.rst: kept 13.4'sabsRefPrefix,compressCss/compressJsand the un-renamedhtmlTag.attributesconfval. Dropped
linkSecurityRelValue(versionadded:: 14.2) andmain's renamed/expandedhtmlTag.attributes.[attribute]examples.UserTsconfig/Options.rst: droppedliveSearchandsearchByFrontendUri(bothversionadded:: 14.2).Verified that no 14.x-only content leaked in, that no headings remain in
front of indented confvals, that heading underline lengths match, and
that
make test-docspasses.