fix: clear PUBLIC_HEADER before re-installing json schema validator#169
Open
BrianMichell wants to merge 1 commit into
Open
fix: clear PUBLIC_HEADER before re-installing json schema validator#169BrianMichell wants to merge 1 commit into
BrianMichell wants to merge 1 commit into
Conversation
The bundled nlohmann_json_schema_validator declares its PUBLIC_HEADER with a path relative to its own source tree. Re-installing the target from the mdio scope resolved that path against the wrong directory, so make install aborted on a missing nlohmann/json-schema.hpp. Clear the property before install(TARGETS) so the redundant header copy is skipped; the validator still installs its own header and the export set is preserved. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled nlohmann_json_schema_validator declares its PUBLIC_HEADER with a path relative to its own source tree. Re-installing the target from the mdio scope resolved that path against the wrong directory, so make install aborted on a missing nlohmann/json-schema.hpp. Clear the property before install(TARGETS) so the redundant header copy is skipped; the validator still installs its own header and the export set is preserved.