Change how EmuHawk handles SRAM - #4813
Draft
SuuperW wants to merge 8 commits into
Draft
Conversation
…atever file was opened
respect user's .bak setting
… say no or any time SRAM is manually saved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means EmuHawk will never automatically overwrite any SRAM file, and will not clutter the SRAM folder with files from movies.
I'm not fully happy with this, but I am not sure how to make it better. The dialog asking the user if they want to save on close could probably use a "remember my choice" option. A better flow for loading a ROM with a specific SRAM might be something to implement.
Check if completed: