Skip to content

Initial support for working with FormXml.#2

Open
hajekj wants to merge 3 commits into
masterfrom
users/jan.hajek/FormXml
Open

Initial support for working with FormXml.#2
hajekj wants to merge 3 commits into
masterfrom
users/jan.hajek/FormXml

Conversation

@hajekj

@hajekj hajekj commented Jun 2, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread src/model/formXml/FormXmlBuilder.ts Outdated
Comment on lines +111 to +112

_buildColumn(): FormXmlColumn {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't columns have their own builder? tab would allow you to add column with the builder on which sections could be added

Comment thread src/model/formXml/FormXmlBuilder.ts Outdated
id: options.id ?? `{${generateGuid()}}`,
showlabel: true,
showbar: false,
columns: 1,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would parse these from options

Comment thread src/model/formXml/FormXmlBuilder.ts Outdated
const tab: FormXmlTab = {
name: options.name,
id: options.id ?? `{${generateGuid()}}`,
showlabel: true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parse from options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants